Update error for mutually exclusive #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwootten
force-pushed
the
update-mutually-exclusive-error
branch
from
e338df8 to
4bdedac
Compare
ajmaddaford
approved these changes
Sep 28, 2020
| "Enter an answer to continue", | ||
| format_message_with_title( | ||
| error_messages["MANDATORY_CHECKBOX"], question_schema.get("title") | ||
| ), |
There was a problem hiding this comment.
I think this test should test the standard error message rather than the checkbox one.
MebinAbraham
requested changes
Sep 28, 2020
MebinAbraham
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
All mutually exclusive mandatory questions need to change to when only checkboxes are used for each answer type:
They should remain as:
How to review
Use the
test_mutually_exclusiveschema to confirm that errors displayed as expected. (New mandatory with differing answer type added)