Fix Welsh ordinals over 20 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajmaddaford
approved these changes
Sep 4, 2020
berroar
reviewed
Sep 7, 2020
There was a problem hiding this comment.
This is correct as described on the trello card, but just to point out that ain comes from the Welsh word for twenty: hugain, which is why previously 21 to 39 used the ain indicator, as for example in welsh you say "one on twenty" for 21 etc. up to 39. So not sure why we are switching from "fed" which I believe is correct for 40 plus.
MebinAbraham
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This changes how Welsh ordinals are generated. All ordinals over 20 have the "ain" suffix now. Change is described on this Trello card.
How to review
Run
test_placeholder_transformsunit test.Checklist