Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Address answer type #261
Introduce Address answer type #261
Changes from all commits
94b9f9d
b01c10b
81e6960
9796d18
9340169
e67e94b
61f80ea
162bb9b
1e0dbbd
05b8f1a
35ceb4f
b3322fe
cf21b93
35dd9bd
cfaa712
b5c92e1
a8a1590
58b9388
67f4efa
1168a47
4417f38
47f71b1
05d9b2e
8d95d89
6fd61b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not 100% sure what this is doing, looks to me if answer_value is a dict make another dict with all the empties removed. Then check it's not completely empty at a later stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just filtering out any
EMPTY_ANSWER_VALUES
when the answer is a dict i.e address since we don't store any answers that matchEMPTY_ANSWER_VALUES
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added because the DS component requires this at the moment. This bug will be fixed in the DS soon.