Request IR by text message #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/integration/individual_response/test_individual_response.py
Outdated
Show resolved
Hide resolved
tests/integration/individual_response/test_individual_response.py
Outdated
Show resolved
Hide resolved
Co-authored-by: James Gardiner <[email protected]>
MebinAbraham
approved these changes
Aug 27, 2020
JamesGardiner
approved these changes
Aug 27, 2020
The app doesn't work in Docker with the latest datastore library as the way emulator credentials work has been changed in 1.15. We are fixing on 1.14 temporarily, as soon as this merges we will update to 1.15 in a separate pull request.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Adds the journey to request an individual response by text message shown in the prototype. Encrypts the mobile number from view in the url. Validation is not handled and will follow on a separate card.
NB: I couldn't see why the person_id would be present in the url so I've not included it. This also follows how the post url structure. I'm away until the end of the month so this will need to be picked up by someone else in my absence.
How to review
See if you agree with the approach.