Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor form import structure #244

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Conversation

JamesGardiner
Copy link
Contributor

What is the context of this PR?

Refactors the form and form field module layout and import structure.

How to review

Check no existing functionality is impacted

@JamesGardiner JamesGardiner marked this pull request as ready for review August 18, 2020 12:43
@pricem14pc pricem14pc added this to the v3.48.0 milestone Aug 19, 2020
Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the new structure.

Copy link
Contributor

@petechd petechd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now and works fine in local schemas!

@JamesGardiner JamesGardiner merged commit adbaffa into master Aug 24, 2020
@JamesGardiner JamesGardiner deleted the refactor-form-module-layout branch August 24, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants