Add actions for list collectors and remove old code #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LJBabbage
commented
Aug 14, 2020
scripts/run_validator.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| tag=latest | |||
| tag=add-answer-action-for-lists | |||
There was a problem hiding this comment.
To revert back later
ajmaddaford
reviewed
Aug 18, 2020
ajmaddaford
approved these changes
Aug 20, 2020
MebinAbraham
previously approved these changes
Aug 20, 2020
MebinAbraham
dismissed
their stale review
Waiting on confirmation on validator changes.
MebinAbraham
previously approved these changes
Aug 20, 2020
MebinAbraham
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Add_answer, remove_answer and add_or_edit_answer has been replaced with answer actions for lists, this PR updates the code to allow actions to be used. It also updates all the test_schemas
How to review
Make sure lists still works as expected, when adding, removing and editing, this include primary as well
Checklist