Create new functional test suites and add timeout #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
force-pushed
the
add-func-test-timeout
branch
from
93f95b3 to
857d1fa
Compare
berroar
changed the title
liamtoozer
approved these changes
Oct 18, 2024
petechd
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Adds a timeout of
30mfor our functional tests.Bumps the number of functional test instances from
1to2.Splits out functional tests into more suites, created a folders called
Summaries,JourneysandList_Collector. Moved existing tests from theFunctionalandGeneralsuites to these new folders.How to review
Check that tests pass (note: we still have issues with flaky tests, but with this change we should be able to re-run suites faster than before).
Checklist