-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update packages and version to Python 3.12 #1530
Conversation
Benchmark Results |
Needs a PR description though I accept the change is fairly obvious 😆 |
The stats here are not great, and although they have been up and down recently in benchmark i think it is worth running some more tests to assess whether there are some performance implications here. |
Benchmark Results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do a Performance investigation in benchmark?
Benchmark Results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, and benchmark results seem similar to the results you have run.
Benchmark Results |
Benchmark Results |
What is the context of this PR?
This updates project's Python to version 3.12 and updates some of the dev libraries since the poetry lock required regeneration as well. As a result some new flake8 config and some test changes had to be made.
How to review
Run benchmark and test all the places where Python got updated.
Checklist