Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pub/sub unit test #1507

Merged
merged 8 commits into from
Sep 16, 2024
Merged

Fix pub/sub unit test #1507

merged 8 commits into from
Sep 16, 2024

Conversation

liamtoozer
Copy link
Contributor

@liamtoozer liamtoozer commented Sep 10, 2024

What is the context of this PR?

A recent PR was raised to remove a failing Pub/Sub unit test (#1504), which was asserting an API response exception from GCP directly. This was causing failures because GCP had changed their error message text.

Instead, we can just assert that the exception is raised in our function, and patch the pub/sub exception so that we don't query GCP directly

How to review

Check that the test passes and that it makes sense

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

Copy link
Contributor

@Yuyuutsu Yuyuutsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relook - changes look good, and works as expected

Copy link
Contributor

@petechd petechd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much we can do here, except the changes you've made. Unit test is relying on external APIs.

@liamtoozer liamtoozer merged commit 91761b5 into main Sep 16, 2024
17 checks passed
@liamtoozer liamtoozer deleted the fix-pubsub-unit-test branch September 16, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants