Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove save on signout code #142

Merged
merged 3 commits into from
Jun 11, 2020
Merged

Conversation

ajmaddaford
Copy link
Contributor

What is the context of this PR?

Removes redundant save on signout code and tests. This hasn't been used since the signout button was changed to a link in ONSdigital/eq-survey-runner#2277.

As part of this work a new signed-out endpoint has been added to differentiate it from sign-out. sign-out does the work of signing out and redirecting to either a provided log out url or the signed-out page.

The sign out button logic has been simplified to remove the check for an account_service_log_out_url. This was to hide the sign out button on the thank-you page. Instead there is now an explicit property hide_signout_button and cookie state modification on the GET of the thank-you page has been removed.

How to review

  • Check that all code related to save on signout has been removed
  • Check that tests that have been removed should have been

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@ajmaddaford ajmaddaford force-pushed the remove-save-on-signout-code branch from efa62a7 to 330e404 Compare June 9, 2020 13:34
@ajmaddaford ajmaddaford force-pushed the remove-save-on-signout-code branch from 330e404 to 444cdcb Compare June 9, 2020 13:56
@pricem14pc pricem14pc added this to the v3.44.0 milestone Jun 10, 2020
Copy link
Contributor

@LJBabbage LJBabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, bar the odd comment in the tests

@ajmaddaford ajmaddaford merged commit 7e7adc9 into master Jun 11, 2020
@ajmaddaford ajmaddaford deleted the remove-save-on-signout-code branch June 11, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants