Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Removes redundant save on signout code and tests. This hasn't been used since the signout button was changed to a link in ONSdigital/eq-survey-runner#2277.
As part of this work a new
signed-out
endpoint has been added to differentiate it fromsign-out
.sign-out
does the work of signing out and redirecting to either a provided log out url or thesigned-out
page.The sign out button logic has been simplified to remove the check for an
account_service_log_out_url
. This was to hide the sign out button on thethank-you
page. Instead there is now an explicit propertyhide_signout_button
and cookie state modification on the GET of thethank-you
page has been removed.How to review
Checklist