Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints for Publisher Module #1364

Merged
merged 7 commits into from
May 23, 2024
Merged

Type hints for Publisher Module #1364

merged 7 commits into from
May 23, 2024

Conversation

VirajP1002
Copy link
Contributor

@VirajP1002 VirajP1002 commented May 13, 2024 •
edited
Loading

What is the context of this PR?

  • Added type hinting to the Publisher module to align with other modules with type hinting in place.

How to review

  • Ensure type hints are correct and if amendments are required

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@VirajP1002 VirajP1002 marked this pull request as ready for review May 13, 2024 15:46
@VirajP1002 VirajP1002 merged commit 8db9577 into main May 23, 2024
16 checks passed
@VirajP1002 VirajP1002 deleted the publisher-module-type-hints branch May 23, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamtoozer liamtoozer liamtoozer left review comments

@rmccar rmccar rmccar approved these changes

@Yuyuutsu Yuyuutsu Yuyuutsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VirajP1002 @liamtoozer @rmccar @Yuyuutsu