Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dependabot config file #1360

Merged
merged 9 commits into from
May 28, 2024
Merged

Add Dependabot config file #1360

merged 9 commits into from
May 28, 2024

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Apr 30, 2024

What is the context of this PR?

This adds config of Dependabot for Runner so we can group packages updates into single PRs and ignore specific ones. Check the config documentation

How to review

Follow this guide: https://docs.github.com/en/code-security/getting-started/dependabot-quickstart-guide#prerequisites. Fork https://github.com/dependabot/demo add dependabot.yaml with some config and enable dependabot.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@petechd petechd marked this pull request as ready for review April 30, 2024 22:25
@ONSdigital ONSdigital deleted a comment from ons-eq-team May 7, 2024
@VirajP1002
Copy link
Contributor

Would python-snappy be either a dev or prod dependency? In my fork, it separates the prod and dev dependencies as expected but there's one additional PR addressing python-snappy

@petechd
Copy link
Contributor Author

petechd commented May 24, 2024

Would python-snappy be either a dev or prod dependency? In my fork, it separates the prod and dev dependencies as expected but there's one additional PR addressing python-snappy

Well spotted! I've added a wildcard (seems like I missed it when creating this config) so anything python will be grouped in prod dependencies, since python-snappy is in prod deps.

Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a fork, and the dependabot is correctly organising the dependencies into dev or prod groups, LGTM 👍

@petechd petechd merged commit b69b05d into main May 28, 2024
16 checks passed
@petechd petechd deleted the add-dependabot-config branch May 28, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants