Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace raw url on thank-you page #1343

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Mar 28, 2024

What is the context of this PR?

This replaces the raw URL as a link text on the thank-you page template. Previously, it didn't provide enough context for screen readers and made navigation difficult without the surrounding information. Translations also had to be updated.

How to review

Load a schema with thank-you page and the link enabled and visible (there is extra template logic for when the link is displayed). Check if the new link text is displayed.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@petechd petechd marked this pull request as ready for review March 28, 2024 11:07
templates/thank-you.html Outdated Show resolved Hide resolved
Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes pass and the html changes look good to me - I had a look in a few schemas and the changes look good 👍

@petechd petechd merged commit 3a3e7e1 into main Apr 3, 2024
16 checks passed
@petechd petechd deleted the dac-runner-raw-url-replacement branch April 3, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants