-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backup name env var handling in restore CI task #1324
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petechd
changed the title
Add no backup name var handling in restore CI script
Add backup name env var handling in restore CI script
Feb 26, 2024
petechd
changed the title
Add backup name env var handling in restore CI script
Add backup name env var handling in restore CI task
Feb 26, 2024
berroar
reviewed
Feb 29, 2024
MebinAbraham
reviewed
Mar 5, 2024
MebinAbraham
reviewed
Mar 8, 2024
MebinAbraham
approved these changes
Mar 8, 2024
berroar
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Currently we don't handle situations where the BACKUP_NAME env var is not provided (and there is no default hardcoded). The script tries to extract export metadata with no backup name appended to it and it fails but the error is not clear. This updates the script so it warns that the var needs to be set.
How to review
Fly execute the
restore_questionnaire_state.yaml
file, without providing the BACKUP_NAME var and check if it errors and you get the"BACKUP_NAME variable must be set"
message. Fly execute with BACKUP_NAME and check if you don't get the same error.Checklist