Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backup name env var handling in restore CI task #1324

Merged
merged 15 commits into from
Mar 8, 2024

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Feb 26, 2024

What is the context of this PR?

Currently we don't handle situations where the BACKUP_NAME env var is not provided (and there is no default hardcoded). The script tries to extract export metadata with no backup name appended to it and it fails but the error is not clear. This updates the script so it warns that the var needs to be set.

How to review

Fly execute the restore_questionnaire_state.yaml file, without providing the BACKUP_NAME var and check if it errors and you get the "BACKUP_NAME variable must be set" message. Fly execute with BACKUP_NAME and check if you don't get the same error.

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@petechd petechd marked this pull request as ready for review February 26, 2024 08:43
@petechd
Copy link
Contributor Author

petechd commented Feb 26, 2024

@petechd petechd changed the title Add no backup name var handling in restore CI script Add backup name env var handling in restore CI script Feb 26, 2024
@petechd petechd changed the title Add backup name env var handling in restore CI script Add backup name env var handling in restore CI task Feb 26, 2024
@petechd petechd merged commit 3f9eb50 into main Mar 8, 2024
16 checks passed
@petechd petechd deleted the add-no-backup-name-var-message branch March 8, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants