Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Runner Python Packages #1322

Merged
merged 22 commits into from
Mar 7, 2024
Merged

Conversation

Yuyuutsu
Copy link
Contributor

@Yuyuutsu Yuyuutsu commented Feb 21, 2024

What is the context of this PR?

Update python packages.
Changes Made:

  • Fixed any new type hinting errors found
  • Flake8 Config has been updated to accommodate new black update. [Black docu
    (https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#:~:text=Flake8%23,E203%2C%20E704)
  • Pylint has been pinned due to problems with how Pylint interacts with pylint_quotesin versions3.*.*. There has been an issue raised and a PR to resolve the issue with pylint_quotes, but owner of the repoistory has not merged yet. See issue here
  • dynamodb() test has been updated to use mock_aws due to moto v5.0.0
  • Google Publisher Mock has been updated

How to review

  • Check if tests and runner runs as expected
  • Check if changes make sense

Benchmark Results

Main Branch

Baseline benchmark

Update Runner Python Package

Update Runner Python Package branch

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@Yuyuutsu Yuyuutsu marked this pull request as ready for review February 21, 2024 12:00
@Yuyuutsu
Copy link
Contributor Author

Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a benchmark run as discussed 👍

Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to regenerate the piplock file as we have now updated the sdc-cryptography repo to fix some dependabot issues: https://github.com/ONSdigital/sdc-cryptography/releases/tag/1.1.4

Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All the tests pass and the changes make sense to me! 🎉

Copy link
Contributor

@liamtoozer liamtoozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me! 👍

@MebinAbraham MebinAbraham merged commit b1e8d85 into main Mar 7, 2024
16 checks passed
@MebinAbraham MebinAbraham deleted the update-runner-python-packages branch March 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants