-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Runner Python Packages #1322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs a benchmark run as discussed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to regenerate the piplock file as we have now updated the sdc-cryptography repo to fix some dependabot issues: https://github.com/ONSdigital/sdc-cryptography/releases/tag/1.1.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! All the tests pass and the changes make sense to me! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me! 👍
What is the context of this PR?
Update python packages.
Changes Made:
(https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#:~:text=Flake8%23,E203%2C%20E704)
Pylint
has been pinned due to problems with howPylint
interacts withpylint_quotes
in versions3.*.*
. There has been an issue raised and a PR to resolve the issue withpylint_quotes
, but owner of the repoistory has not merged yet. See issue heredynamodb()
test has been updated to usemock_aws
due tomoto v5.0.0
How to review
Benchmark Results
Main Branch
Update Runner Python Package
Checklist