Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template content for Calculated Summary & Grand Calculated Summary #1310

Merged
merged 8 commits into from
Feb 1, 2024

Conversation

liamtoozer
Copy link
Contributor

@liamtoozer liamtoozer commented Jan 30, 2024

What is the context of this PR?

Tweaks button wording and removes blue banner help from screen to match updated content design.

Note: This update caused a few other areas to translations message file to change

How to review

Load test_calculated_summary schema, navigate to the calculated summary screen and ensure that the rendered page matches the spec shown in the Trello ticket

Checklist

  • New static content marked up for translation

@liamtoozer
Copy link
Contributor Author

Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we were able to update this and looks like nothing broke/no tests needed to change, it is probably worth adding a test somewhere that checks this text 👍

Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MebinAbraham MebinAbraham added the dont merge Don't merge this PR label Feb 1, 2024
@MebinAbraham
Copy link
Contributor

MebinAbraham commented Feb 1, 2024

Waiting for confirmation that Grand Calc Summary should have also been updated (I would assume so)

@MebinAbraham
Copy link
Contributor

Confirmed both Calc and Grand Calc should be the same.

@MebinAbraham MebinAbraham removed the dont merge Don't merge this PR label Feb 1, 2024
@liamtoozer liamtoozer changed the title Update template wording for Calculated Summary Update template content for Calculated Summary & Grand Calculated Summary Feb 1, 2024
@liamtoozer liamtoozer merged commit e054b0e into main Feb 1, 2024
16 checks passed
@liamtoozer liamtoozer deleted the calculated-summary-content-content-change branch February 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants