Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to DS 67.0.5 #1305

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Update to DS 67.0.5 #1305

merged 2 commits into from
Jan 29, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Jan 23, 2024

What is the context of this PR?

Updates to DS version 67.0.5

How to review

Load a few schemas and see if they still look and work as expected

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@rmccar rmccar marked this pull request as ready for review January 24, 2024 11:40
@rmccar
Copy link
Contributor Author

rmccar commented Jan 24, 2024

Update to DS version 67.0.5

Yuyuutsu
Yuyuutsu approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@Yuyuutsu Yuyuutsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only difference between staging is that the header and footer link gap size. But I think that was an issue with staging being deployed unlike a local instance, if I remember right.

@rmccar
Copy link
Contributor Author

rmccar commented Jan 26, 2024

Looks good, only difference between staging is that the header and footer link gap size. But I think that was already a known thing if I remember right.

Oh yeah that was down to the html minification I think we have a card to look into this

@rmccar rmccar merged commit 86a81aa into main Jan 29, 2024
16 checks passed
@rmccar rmccar deleted the update-to-ds-67.0.5 branch January 29, 2024 08:48
petechd pushed a commit that referenced this pull request Jan 30, 2024
@rmccar @petechd
Update to DS 67.0.5 (#1305)
e53cd2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuyuutsu Yuyuutsu Yuyuutsu approved these changes

@berroar berroar berroar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rmccar @berroar @Yuyuutsu