Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Runner test script improperly generating survey metadata #1302

Merged
merged 28 commits into from
Feb 28, 2024
Merged

Runner test script improperly generating survey metadata #1302

merged 28 commits into from
Feb 28, 2024

Conversation

VirajP1002
Copy link
Contributor

@VirajP1002 VirajP1002 commented Jan 22, 2024 •
edited
Loading

What is the context of this PR?

create_token.py had a method that was broken leading to metadata not being handled correctly in particular for any non-v1 create_token method. In order to fix this, logic was added to ensure additional metadata was placed in survey_metadata which is the correct level. Tests had to be added in test_login as the bug was non-existent without those tests in place.

A test suite for the create_token.py test script was created in order to demonstrate that a token was being generated correctly and that metadata was being placed at the correct level and the contents were correct.

How to review

  • Ensure the changes made are appropriate
  • Ensure unit tests pass

Checklist

  • New static content marked up for translation
  • Newly defined schema content included in eq-translations repo

@VirajP1002
Copy link
Contributor Author

Bug: Runner test cases improperly generating survey metadata

berroar
berroar reviewed Feb 14, 2024
View reviewed changes
tests/integration/test_create_token.py Outdated Show resolved Hide resolved
tests/integration/test_create_token.py Outdated Show resolved Hide resolved
@VirajP1002 VirajP1002 changed the title Runner improperly generating survey metadata Runner test script improperly generating survey metadata Feb 19, 2024
berroar
berroar reviewed Feb 26, 2024
View reviewed changes
tests/integration/test_create_token.py Outdated Show resolved Hide resolved
tests/integration/test_create_token.py Outdated Show resolved Hide resolved
tests/integration/test_create_token.py Outdated Show resolved Hide resolved
berroar
berroar approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tests/integration/test_create_token.py Outdated Show resolved Hide resolved
@VirajP1002 VirajP1002 merged commit c5fdfe3 into main Feb 28, 2024
16 checks passed
@VirajP1002 VirajP1002 deleted the runner-tests-improper-survey-metadata branch February 28, 2024 14:42
@MebinAbraham MebinAbraham added the Bug Fix Something isn't working label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petechd petechd petechd approved these changes

@berroar berroar berroar approved these changes

Assignees
No one assigned
Labels
Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VirajP1002 @berroar @petechd @MebinAbraham