Fix mass-metric-ton units handling
#1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katie-gardner
suggested changes
Jun 26, 2023
katie-gardner
approved these changes
Jun 26, 2023
berroar
approved these changes
Jun 26, 2023
Yuyuutsu
approved these changes
Jun 26, 2023
kylelawsonAND
approved these changes
Jun 26, 2023
MebinAbraham
added a commit
that referenced
this pull request
Jul 5, 2023
Fix handling of invalid values in form numerical inputs (#1111) Fix dynamic answers functional test (#1121) Add schema changes for validator format_unit using calculated summary source validation fix (#1142) Fix mass-metric-ton units handling (#1146) Fix unit label hover title for metric ton (#1150) Fix list collector placeholders not resolving when preview enabled (#1151)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
mass-metric-tonis no longer supported foren_GBand related locales, but still present in business schema and allowed in validator. Until removed from schema and validator definitions we want to substitutemass-tonformass-metric-tonand vice versa, before and after unit formatting.How to review
New test cases in existing unit tests.
Checklist