-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable load metadata button when fields aren't passing validation #90
Conversation
…igital/eq-questionnaire-launcher into enable-disable-load-metadata-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor - however, when following the steps:
- I loaded metadata by
Remote Schemas
where I chose the survey type and schema then the button was enabled - Then I loaded metadata by
Schema Name
and this disabled theLoad Metadata
button as expected - But then I loaded metadata by
Remote Schema
again, and I only added the survey type and not the schema name and the button was enabled which I'm guessing isn't correct
Happy to jump in a huddle if that doesn't make sense
Should be fixed now if you want to give it another test when you get chance |
…igital/eq-questionnaire-launcher into enable-disable-load-metadata-button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great for me 👍
What is the context of this PR?
This PR refactors the way buttons are enabled and disabled and updates launcher to disable the "load metadata" button when the correct fields aren't selected
How to review