Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable load metadata button when fields aren't passing validation #90

Merged
merged 16 commits into from
Sep 16, 2024

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Aug 12, 2024

What is the context of this PR?

This PR refactors the way buttons are enabled and disabled and updates launcher to disable the "load metadata" button when the correct fields aren't selected

How to review

  • Test that the "load metadata" button is only enabled when the metadata fields are selected and/or input
  • Test that it is then disabled again when local storage is cleared
  • Test that it is enabled and disabled when the metadata fields are selected and/or input and then cleared again

Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor - however, when following the steps:

  • I loaded metadata by Remote Schemas where I chose the survey type and schema then the button was enabled
  • Then I loaded metadata by Schema Name and this disabled the Load Metadata button as expected
  • But then I loaded metadata by Remote Schema again, and I only added the survey type and not the schema name and the button was enabled which I'm guessing isn't correct

Happy to jump in a huddle if that doesn't make sense

@rmccar
Copy link
Contributor Author

rmccar commented Aug 23, 2024

Minor - however, when following the steps:

  • I loaded metadata by Remote Schemas where I chose the survey type and schema then the button was enabled
  • Then I loaded metadata by Schema Name and this disabled the Load Metadata button as expected
  • But then I loaded metadata by Remote Schema again, and I only added the survey type and not the schema name and the button was enabled which I'm guessing isn't correct

Happy to jump in a huddle if that doesn't make sense

Should be fixed now if you want to give it another test when you get chance

Copy link
Contributor

@liamtoozer liamtoozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me 👍

@rmccar rmccar merged commit c74b8a9 into main Sep 16, 2024
3 checks passed
@rmccar rmccar deleted the enable-disable-load-metadata-button branch September 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants