Fix issue where the launch survey button being was disabled incorrectly #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirajP1002
reviewed
Jul 12, 2024
VirajP1002
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The launch survey button being was disabled incorrectly when launching a supplementary data schema, then going back to launcher and opening a non supplementary data schema. This was due to an unnecessary call to the enableSubmitFlushButtons function when the handleNoSupplementaryData function was being called.
How to review
Check that you are able to open a supplementary data schema, then launch a non supplementary data schema. Check no other scenarios are broken.