Display SDS dataset IDs either with survey metadata or in SDS section #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petechd
reviewed
May 2, 2024
petechd
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
To allow launching of business prepop surveys, our Launcher service needs to be altered to handle:
dataset_ideither in survey metadata (if present) or in the SDS sectionsurvey_idto Runner if it's a business survey only if thesurvey_idis not present in the survey metadataHow to review
Run with the Mock SDS branch. Ensure that all relevant prepop surveys launch correctly and display the prepop data in Runner.
There might be other launch scenarios that I've missed, so would be grateful for any advice if so
Jira: https://jira.ons.gov.uk/browse/ECI-1122