Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to launch using the v1 pattern #71

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

berroar
Copy link
Contributor

@berroar berroar commented Apr 5, 2024

What is the context of this PR?

Removes the ability to launch surveys using the v1 format. v1 was deprecated but support in runner is now being removed so we will no longer need to launch using this pattern.

How to review

Check references to the v1 launch pattern have been removed.
Check that you are still able to launch surveys using the v2 pattern.

@berroar berroar marked this pull request as ready for review April 8, 2024 12:26
@berroar berroar changed the title Remove ability to launch v1 pattern Remove ability to launch using the v1 pattern Apr 8, 2024
Copy link
Contributor

@liamtoozer liamtoozer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me 👍

launch.go Show resolved Hide resolved
Copy link
Contributor

@VirajP1002 VirajP1002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't see any mentions to the v1 pattern and I opened several schemas successfully!

@berroar berroar merged commit 791e9a3 into main Apr 24, 2024
3 checks passed
@berroar berroar deleted the remove-support-for-v1-launch-pattern branch April 24, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants