-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix url schema launch #62
Conversation
1be4d18
to
3bb02d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for v2 launching 👍
Doesn't work for v1, the launch errors because runner is expecting eq_id and form_type or the schema name, but in this case it doesn't have it
I think possibly the change for the v1 launch pattern should be undone? Since the validation in runner for v1 is ok with it the way it was, just v2 that doesn't work
45fe402
to
85553df
Compare
Fixed this now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to be working for me 👍
I still seem to get this error, when launching a test schema by URL in v1 (was using test_checkbox) 🤔 |
Im not seeing this, what are the steps are you doing to get the error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working as expected now 👍
What is the context of this PR?
This makes the change to only send the schema url to runner when launching via a schema url
Also fixes the alignment of the arrow icon next to the load previous value button and tidys up the code a bit.
How to review
https://raw.githubusercontent.com/ONSdigital/eq-questionnaire-schemas/main/schemas/business/en/1_0005.json
http://localhost:8000/quick-launch?url=https://raw.githubusercontent.com/ONSdigital/eq-questionnaire-schemas/main/schemas/business/en/1_0005.json