Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ru_ref #61

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Update ru_ref #61

merged 2 commits into from
Dec 14, 2023

Conversation

MebinAbraham
Copy link
Contributor

What is the context of this PR?

Update ru_ref to be consistent with Runner.

How to review

Ensure launcher is unchanged functionally.

berroar
berroar previously approved these changes Dec 14, 2023
katie-gardner
katie-gardner previously approved these changes Dec 14, 2023
@MebinAbraham
Copy link
Contributor Author

MebinAbraham commented Dec 14, 2023

@berroar @katie-gardner I had to update the Dockerfile as it was erroring, but it seems to be error on a step that we shouldn't need. Can you build the image and run it locally and ensure it is working as expected. No issues on my end.

Build: docker build -t eq-questionnaire-launcher:latest .
Run: docker run -e SURVEY_RUNNER_SCHEMA_URL=http://host.docker.internal:5000 -it -p 8000:8000 eq-questionnaire-launcher:latest

Test that you can launch a survey.

@MebinAbraham MebinAbraham dismissed stale reviews from katie-gardner and berroar December 14, 2023 09:20

Changes

Copy link
Contributor

@berroar berroar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the new docker image and was able to launch 👍

@MebinAbraham MebinAbraham merged commit a4e3120 into main Dec 14, 2023
2 checks passed
@MebinAbraham MebinAbraham deleted the update-ru-ref branch December 14, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants