-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save schema and response id to local storage #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as intended - the saving is great 🎉
Only though I have re button, is it might be more intuitive for the odd other person using launcher if it is next to the field
maybe something like
?
not sure what you think of something like that? but happy to go as is, either works so feel free to leave that one. If the button is at the bottom I think I'd also go with it saying "Load Previous Response ID" instead for clarity
…eq-questionnaire-launcher into save-schema-name-response-id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could possibly fix CSS if its simple but extra features working nicely 👍 happy as is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What is the context of this PR?
This adds js localStorage property usage to launcher. Schema name and response id are now saved and can be retrieved or deleted. New buttons added to the launcher html page and extra option of clearing local storage added, otherwise loading schema from url is permanently disabled when storage elements exist and have to be cleared manually.
How to review
Run locally using
go run launch.go
and test all the options manually.