Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify schema URL #40

Merged
merged 5 commits into from
Apr 26, 2022
Merged

Conversation

MebinAbraham
Copy link
Contributor

@MebinAbraham MebinAbraham commented Apr 20, 2022

What is the context of this PR?

  • Added the ability to specify a schema URL instead of selecting a schema from runner.
  • Specifying a URL means that the runner claims will include a survey_url field which runner will use to launch.

Note: Runner current implementation requires schema_name or eq_id and form_type. Therefore, when launching using a URL, schema name is passed for test schemas and for non test schema eq_id and form_type are passed. This is likely to change in future iterations.

How to review

Run this branch via docker or locally.
Note: You need to clear your browsers cache since the CSS has changed.

Ensure:

  • you are able to specify a schema URL and launch the questionnaire. Validate runner did in fact launch using survey_url and was not loaded from file system. Use a schema that doesn't exist in runner.
  • the existing behaviour of selecting from the schema list is unaffected.
  • when launching using a schema URL, runner's downstream payload contains collection.schema_name.

@MebinAbraham MebinAbraham merged commit 998ab34 into master Apr 26, 2022
@MebinAbraham MebinAbraham deleted the ability-to-load-schema-from-url branch April 26, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants