Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse launcher schema by survey type #35

Merged
merged 5 commits into from
Dec 9, 2021
Merged

Conversation

MebinAbraham
Copy link
Contributor

@MebinAbraham MebinAbraham commented Dec 2, 2021

What is the context of this PR?

Updates launcher to work with ONSdigital/eq-questionnaire-runner#731
Runner schemas are now grouped by survey type. The changes have been kept to a minimum, could be refactored further but didn't think it was worth it.

How to review

  • Run this branch of launcher locally or point your launcher to this branch in runner's docker compose file.
  • Ensure launcher works as expected and no existing functionality have been broken..
  • Add a new survey type dir into runner schemas/ dir with an appropriate schema and ensure launcher is able to pick it up.

Copy link
Contributor

@LJBabbage LJBabbage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I tested social and business, added another survey type and added metadata, all was good. I even added a welsh version into one of the business surveys and it worked as before. I did see a problem with json file name which I will put on the other PR

surveys/surveys.go Outdated Show resolved Hide resolved
Co-authored-by: Mebin Abraham <[email protected]>
@rmccar rmccar merged commit c61a541 into master Dec 9, 2021
@rmccar rmccar deleted the parse-schemas-by-survey-type branch December 9, 2021 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants