Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get image tag from deploy_app task inputs #32

Merged
merged 2 commits into from
Aug 6, 2021

Conversation

petechd
Copy link
Contributor

@petechd petechd commented Aug 4, 2021

What is the context of this PR?

This is complementary PR for the eq-pipelines changes in this PR.

How to review

Fly your pipeline using image of the app in this PR or check my pipeline where I used these settings.

@petechd
Copy link
Contributor Author

petechd commented Aug 4, 2021

Copy link
Contributor

@MebinAbraham MebinAbraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to manually tag v1.4.0 and push until we have something automatic in place.

@pricem14pc pricem14pc self-requested a review August 5, 2021 17:18
Copy link

@pricem14pc pricem14pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully in an eq-test (image-tag file) and eq-staging (default to latest) pipeline. The expected image is deployed correctly.

@petechd petechd merged commit 491a57b into master Aug 6, 2021
@petechd petechd deleted the add-image-tag-to-exports branch August 6, 2021 05:58
pricem14pc added a commit to pricem14pc/eq-questionnaire-launcher that referenced this pull request Aug 20, 2021
Get image tag from deploy_app task inputs (ONSdigital#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants