Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove census specific code #27

Merged
merged 10 commits into from
May 25, 2021
Merged

Remove census specific code #27

merged 10 commits into from
May 25, 2021

Conversation

petechd
Copy link
Contributor

@petechd petechd commented May 19, 2021

What is the context of this PR?

This removes census specific code from survey.go and launch.html. Some code was left in order to test census schemas (test_individual_response.json).

How to review

Use local go launcher as described in readme file to check the changes.

@petechd
Copy link
Contributor Author

petechd commented May 19, 2021

Copy link
Contributor

@ajmaddaford ajmaddaford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a fair bit of Census specific code e.g. TransformSchemaParamsToName in auth.go and Javascript in launch.html.

@petechd
Copy link
Contributor Author

petechd commented May 20, 2021

TransformSchemaParamsToName

I removed census code from "auth.go" but do we want to remove the code in "launch.html" as it's required for launching "test_individual_response" schema?

@petechd
Copy link
Contributor Author

petechd commented May 20, 2021

Removed remaining census functions from "launch.go"

@petechd petechd merged commit 4f5e891 into master May 25, 2021
@MebinAbraham MebinAbraham deleted the remove-census-specific-code branch August 21, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants