Add unit test for remove trailing slash func

ONSdigital · Jul 10, 2024 · 92b5626 · 92b5626
1 parent 6793ab6
commit 92b5626
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/main/java/com/github/onsdigital/dp/uploadservice/api/APIClient.java b/src/main/java/com/github/onsdigital/dp/uploadservice/api/APIClient.java
@@ -110,7 +110,7 @@ private void sendChunk(byte[] chunk, int chunkNumber, int totalChunks, String fi
         }
     }
 
-    private String removeTrailingSlash(String url){
+    protected String removeTrailingSlash(String url){
         if (url.endsWith("/")) {
             return url.substring(0, url.length() - 1);
         }

diff --git a/src/test/java/com/github/onsdigital/dp/uploadservice/api/APIClientTest.java b/src/test/java/com/github/onsdigital/dp/uploadservice/api/APIClientTest.java
@@ -15,6 +15,7 @@
 import java.util.ArrayList;
 import java.util.List;
 
+import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
@@ -90,4 +91,14 @@ void handingIncorrectTokenProvidedResumableFile() {
 
         assertNotNull(e.getCause());
     }
+
+    @Test
+    void testRemoveTrailingSlash() {
+        String url = "http://www.ons.gov.uk//";
+        String expected = "http://www.ons.gov.uk/";
+        APIClient client = new APIClient("http://localhost:123456789", TOKEN);
+        String result = client.removeTrailingSlash(url);
+        assertNotNull(result);
+        assertEquals(expected, result);
+    }
 }