Feature/cache topics impl #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindenmckenzie
requested changes
Jul 9, 2024
cache/mock.go
Outdated
Comment on lines
42
to
47
| mockDataTopic.List = NewSubTopicsMap() | ||
| mockDataTopic.List.AppendSubtopicID("economy", Subtopic{ID: "6734", Slug: "economy", LocaliseKeyName: "Economy", ReleaseDate: timeHelper("2022-10-10T08:30:00Z"), ParentID: ""}) | ||
| mockDataTopic.List.AppendSubtopicID("environmentalaccounts", Subtopic{ID: "1834", Slug: "environmentalaccounts", LocaliseKeyName: "Environmental Accounts", ReleaseDate: timeHelper("2022-10-10T08:30:00Z"), ParentID: "6734"}) | ||
| mockDataTopic.List.AppendSubtopicID("governmentpublicsectorandtaxes", Subtopic{ID: "8268", Slug: "governmentpublicsectorandtaxes", LocaliseKeyName: "Government Public Sector and Taxes", ReleaseDate: timeHelper("2022-10-10T08:30:00Z"), ParentID: "6734"}) | ||
| mockDataTopic.List.AppendSubtopicID("publicsectorfinance", Subtopic{ID: "3687", Slug: "publicsectorfinance", LocaliseKeyName: "Public Sector Finance", ReleaseDate: timeHelper("2022-10-10T08:30:00Z"), ParentID: "8268"}) | ||
| mockDataTopic.List.AppendSubtopicID("internationalmigration", Subtopic{ID: "1234", Slug: "internationalmigration", LocaliseKeyName: "International Migration", ReleaseDate: timeHelper("2022-10-10T08:30:00Z")}) |
There was a problem hiding this comment.
Think we've talked about the lack of need for the concept of 'DataTopic' here before.
cache/private/private_topic_test.go
Outdated
| }) | ||
| }) | ||
| }) | ||
|
|
||
| Convey("Given root topics exist but no topics found", t, func() { | ||
| Convey("Given root topics exist but no data topics found", t, func() { |
There was a problem hiding this comment.
Suggested change
| Convey("Given root topics exist but no data topics found", t, func() { | |
| Convey("Given root topics exist but no topics found", t, func() { |
cache/topic.go
Outdated
| } | ||
|
|
||
| func (tc *TopicCache) GetTopic(ctx context.Context, slug string) (*Subtopic, error) { | ||
| dataTopicCache, err := tc.GetData(ctx, TopicCacheKey) |
There was a problem hiding this comment.
Suggested change
| dataTopicCache, err := tc.GetData(ctx, TopicCacheKey) | |
| topicCache, err := tc.GetData(ctx, TopicCacheKey) |
cache/topic.go
Outdated
| } | ||
| log.Error(ctx, "failed to get the data topic cache", err, logData) |
There was a problem hiding this comment.
Suggested change
| log.Error(ctx, "failed to get the data topic cache", err, logData) | |
| log.Error(ctx, "failed to get the topic cache", err, logData) |
lindenmckenzie
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How to review
Check code is ok.
Who can review
Anyone, not me