Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add known characters to whitelist #297

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

StRhys
Copy link
Contributor

@StRhys StRhys commented Oct 23, 2024

What

This adds some non-ascii characters to search query validation.
Characters

  • en hyphen/dash (windows ALT 0150) –
  • opening single quote (windown ALT 0145) ‘
  • closing single quote (windows ALT 0146) ’

How to review

Run search api
http://localhost:23900/search?q=National+life+tables+–+life+expectancy
http://localhost:23900/search?q=UK+residents‘+visits+abroad

Who can review

Anyone

@StRhys StRhys requested a review from a team as a code owner October 23, 2024 14:39
@StRhys StRhys merged commit eed9944 into develop Oct 24, 2024
5 checks passed
@StRhys StRhys deleted the feature/known-characters-to-search-whitelist branch October 24, 2024 14:13
@StRhys StRhys mentioned this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants