Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add uris endpoint #289

Merged
merged 14 commits into from
Sep 27, 2024
Merged

Feature/add uris endpoint #289

merged 14 commits into from
Sep 27, 2024

Conversation

Oluwawunmi
Copy link
Contributor

@Oluwawunmi Oluwawunmi commented Sep 12, 2024

What

Add /uris endpoint

How to review

I ran the search stack
and this branch
I also done a reindex while port forwarding to sandbox zebedee and dataset api.

Make a POST request to /search/uris with {"uris": ["/economy"] }
Have a play around with different uris, see if it breaks.
Sense check

Who can review

Not me

@Oluwawunmi Oluwawunmi force-pushed the feature/add-uris-endpoint branch 2 times, most recently from 25f4372 to 7fdf51b Compare September 13, 2024 09:55
@Oluwawunmi Oluwawunmi force-pushed the feature/add-uris-endpoint branch from 6d8fbbc to 8a480a3 Compare September 23, 2024 11:29
@Oluwawunmi Oluwawunmi force-pushed the feature/add-uris-endpoint branch from 8a480a3 to 9af0e6d Compare September 24, 2024 02:58
@StRhys StRhys marked this pull request as ready for review September 26, 2024 14:56
Copy link

@dionisislolas dionisislolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StRhys StRhys merged commit 7529163 into develop Sep 27, 2024
5 checks passed
@StRhys StRhys deleted the feature/add-uris-endpoint branch September 27, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants