-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify schema, reindex script and dependencies to support dimensions and population types #202
Merged
DavidSubiros
merged 13 commits into
develop
from
feature/add-population-types-and-dimensions
Mar 23, 2023
Merged
modify schema, reindex script and dependencies to support dimensions and population types #202
DavidSubiros
merged 13 commits into
develop
from
feature/add-population-types-and-dimensions
Mar 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o using latest models from search data extractor and importer
… add validator and create the request data struct directly from the paramteres, which makes the code easier to maintain
…rch request and unit tests
…(e.g. dimensions counts may be filtered by population types, conten types and topics)
…d search-data-importer, undo 'is_based_on' changes, as they are now in the Metadata document, add unit test and fix lint issues
…AND, not set values that are not provided as query params in the search request
DavidSubiros
force-pushed
the
feature/add-population-types-and-dimensions
branch
from
March 22, 2023 13:28
9d22914
to
bfdfbfc
Compare
AWitcherONS
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Work done to prove that the new
elasticsearch
model works for dimensions and population types, corresponding to the spike defined by this trello card. The following trello cards have been implemented in order to prove the spike work:Reindex with models containing
population_type
anddimensions
. Trello cardonSuccess
andonFailure
callbacks on the indexer, otherwise the async errors failed to be reported.Update elasticsearch models to include
population_type
anddimensions
. Trello cardelasticsearch/search-index-=settings.json
)Update search query templates to allow filtering by population type. Trello card
query/templates/search/v710/contentFilters.tmpl
to add the population type filter if present in the struct that is executed against the template.query/templates/search/v710/populationTypeFilters.tmpl
to allow filtering by population type name and/or label.Update search query templates to allow filtering by dimensions. Trello card
query/templates/search/v710/contentFilters.tmpl
to add the dimensions filter if present in the struct that is executed against the template.query/templates/search/v710/dimensionsFilters.tmpl
to allow filtering by dimension name, label and/or raw_label.Update search query templates to allow counting / aggregating by one category, while filtering by the other categories. Trello card
content types
while filtering by other categories:query/templates/search/v710/countContentTypeQuery.tmpl
query/templates/search/v710/countContentTypeHeader.tmpl
query/templates/search/v710/countContentTypeFilters.tmpl
dimensions
while filtering by other categories:query/templates/search/v710/countDimensionsQuery.tmpl
query/templates/search/v710/countDimensionsHeader.tmpl
query/templates/search/v710/countDimensionsFilters.tmpl
population types
while filtering by other categories:query/templates/search/v710/countPopulationTypeQuery.tmpl
query/templates/search/v710/countPopulationTypeHeader.tmpl
query/templates/search/v710/countPopulationTypeFilters.tmpl
topicx
while filtering by other categories:query/templates/search/v710/countTopicQuery.tmpl
query/templates/search/v710/countTopicHeader.tmpl
query/templates/search/v710/countTopicFilters.tmpl
Other refactors with no functional changes:
http.Request
query params (CreateRequests
func), which is then passed to the query package to execute the templatesDockerfile.local
andreflex
so that this repo can be used indp-compose/v2
search stackDepends on the following PRs:
dp-search-data-extractor
, required by the reindex scriptdp-search-data-importer
, required by the reindex scriptHow to review
Who can review
Anyone