bring linting and CI/CD uptodate #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedge
force-pushed
the
feature/secure-redirect
branch
2 times, most recently
from
5a5dc2e to
b373e11
Compare
lindenmckenzie
requested changes
Jul 25, 2024
config/config.go
Outdated
Comment on lines
94
to
111
| // IsSiteDomainURL is true when urlString is a URL and its host ends with `.`+siteDomain (when siteDomain is blank, uses cfg.SiteDomain) | ||
| func IsSiteDomainURL(urlString, siteDomain string) bool { | ||
| if urlString == "" { | ||
| return false | ||
| } | ||
| if siteDomain == "" { | ||
| siteDomain = cfg.SiteDomain | ||
| } | ||
| urlObject, err := url.ParseRequestURI(urlString) | ||
| if err != nil || !strings.HasSuffix(urlObject.Host, "."+siteDomain) { | ||
| return false | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
could we have some light unit testing for this please?
gedge
force-pushed
the
feature/secure-redirect
branch
from
e27d582 to
1949479
Compare
lindenmckenzie
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
add more validate to avoid having someone clicking on ONS buttons/redirects and being sent somewhere nefarious
How to review
does PR pass tests/sanity
Who can review
!me