Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add search service #64

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Feature/add search service #64

merged 2 commits into from
Jul 3, 2024

Conversation

StRhys
Copy link
Contributor

@StRhys StRhys commented Jul 2, 2024

What

This adds an extra service option for search

A couple assumptions about radio behaviours

  • if a service is given, eg /feedback?service=search, then that service radio should be the default one checked
  • then if this is the case the "specific page" input box should be blank

If this isn't the expected behaviour I can change it to only do it when search is given as a service

How to review

Run the feedback controller
Goto http://localhost:25200/feedback?service=search
Check if extra option is there

With search service
image

Without search service
image

Who can review

Frontend

@StRhys StRhys merged commit 6b66773 into develop Jul 3, 2024
5 checks passed
@StRhys StRhys deleted the feature/add-search-service branch July 3, 2024 09:41
@StRhys StRhys mentioned this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants