add navigation cache #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allandegnan
force-pushed
the
feature/add-navigation-cache
branch
from
963717c to
9bdd202
Compare
allandegnan
force-pushed
the
feature/add-navigation-cache
branch
from
9bdd202 to
5bee5b1
Compare
NoelleDL
reviewed
Jan 27, 2023
allandegnan
force-pushed
the
feature/add-navigation-cache
branch
3 times, most recently
from
61fb03f to
d608fc7
Compare
NoelleDL
reviewed
Jan 27, 2023
Makefile
Outdated
| @@ -57,6 +57,6 @@ generate-debug: fetch-renderer-lib | |||
| .PHONY: generate-prod | |||
| generate-prod: fetch-renderer-lib | |||
| cd assets; go run github.com/kevinburke/go-bindata/go-bindata -prefix $(CORE_ASSETS_PATH)/assets -o data.go -pkg assets locales/... templates/... $(CORE_ASSETS_PATH)/assets/locales/... $(CORE_ASSETS_PATH)/assets/templates/... | |||
| { echo "// +build production\n"; cat assets/data.go; } > assets/data.go.new | |||
| { echo "// +build production"; cat assets/data.go; } > assets/data.go.new | |||
There was a problem hiding this comment.
I think this might have been removed to get it running on your machine locally?
NoelleDL
reviewed
Jan 27, 2023
allandegnan
force-pushed
the
feature/add-navigation-cache
branch
4 times, most recently
from
df8a733 to
77ace2c
Compare
allandegnan
force-pushed
the
feature/add-navigation-cache
branch
from
77ace2c to
46dd551
Compare
lindenmckenzie
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added navigation cache using ONSdigital/dp-cache#5
How to review
tunnel dp-api-router, run the dp-frontend-router, and this app. From there you can use the cache.
Who can review
!me