Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional useful data, state to existing logs #418

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Add additional useful data, state to existing logs #418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions api/versions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ func (api *DatasetAPI) putVersion(w http.ResponseWriter, r *http.Request) {

// If update was to add downloads do not try to publish/associate version
if vars[hasDownloads] != trueStringified {
data["updated_state"] = versionUpdate.State
if versionUpdate.State == models.PublishedState {
if err := api.publishVersion(ctx, currentDataset, currentVersion, versionUpdate, versionDetails); err != nil {
handleVersionAPIErr(ctx, err, w, data)
Expand Down Expand Up @@ -324,6 +325,7 @@ func (api *DatasetAPI) detachVersion(w http.ResponseWriter, r *http.Request) {
update := &models.Version{
State: models.DetachedState,
}
logData["updated_state"] = update.State
if _, err = api.dataStore.Backend.UpdateVersion(ctx, versionDoc, update, headers.IfMatchAnyETag); err != nil {
log.Error(ctx, "detachVersion endpoint: failed to update version document", err, logData)
return err
Expand Down