Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IsBasedOn to Metadata model for both generic and cantabular datasets #412

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Add IsBasedOn to Metadata model for both generic and cantabular datasets #412

merged 1 commit into from
Mar 17, 2023

Conversation

DavidSubiros
Copy link
Contributor

What

Trello card: https://trello.com/c/0F6ifzuo/1257-extend-metadata-endpoint-to-return-cantabular-dataset-metadata

  • Add IsBasedOn to Metadat model
  • Map it from the dataset struct for both generic and cantabular datasets.

Missing values in Cantabular metadata have not been mapped, as there was a test to explicitly validate that they are not mapped.

How to review

  • Make sure code changes make sense
  • Make sure unit tests pass

Who can review

Anyone

@DavidSubiros DavidSubiros mentioned this pull request Mar 10, 2023
Merged
@DavidSubiros DavidSubiros merged commit 4a8072c into develop Mar 17, 2023
@DavidSubiros DavidSubiros deleted the feature/extend-metadata branch March 17, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshumoogum nshumoogum nshumoogum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidSubiros @nshumoogum