Make new download objects instead of changing input referenced object #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafahop
force-pushed
the
feature/do-not-change-input-version
branch
from
ef1e5b7 to
4cdf238
Compare
AWitcherONS
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The Metadata object is populated with a reference to the
Downloadsfield of the version passed as a parameter. Only to then override the downloadsPublicandPrivatefields, meaning that we are changing the version (input).This is not a problem currently as the caller of these methods do not do anything with the version but it could potentially result in unexpected results (and wrong unit tests)
Create new download objects using the version values instead, making it more explicit
How to review
Ensure changes do not alter the logic (other than not overriding the input object) and unit tests still pass
Who can review
Anyone