Upgrade dependencies #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookel2
requested changes
Apr 25, 2023
| @@ -106,17 +106,21 @@ func TestDatasetPermissionsRequestBuilder_NewPermissionsRequest(t *testing.T) { | |||
| } | |||
|
|
|||
| req := httptest.NewRequest("GET", testHost, nil) | |||
| headers.SetUserAuthToken(req, "111") | |||
| headers.SetAuthToken(req, "111") | |||
There was a problem hiding this comment.
SetAuthToken returns an error, which is currently unhandled.
| @@ -153,17 +161,21 @@ func TestDatasetPermissionsRequestBuilder_NewPermissionsRequest(t *testing.T) { | |||
| req := httptest.NewRequest("GET", testHost, nil) | |||
|
|
|||
| headers.SetServiceAuthToken(req, "222") | |||
| headers.SetUserAuthToken(req, "333") | |||
| headers.SetAuthToken(req, "333") | |||
There was a problem hiding this comment.
The error needs to be handled here too.
| @@ -48,7 +48,7 @@ func TestPermissionsRequestBuilder_NewPermissionsRequest(t *testing.T) { | |||
| Convey("should return expected error if error creating new http request", t, func() { | |||
| builder := &PermissionsRequestBuilder{Host: "$%^&*(()"} | |||
| inboundReq := httptest.NewRequest("GET", testHost, nil) | |||
| headers.SetUserAuthToken(inboundReq, "666") | |||
| headers.SetAuthToken(inboundReq, "666") | |||
There was a problem hiding this comment.
The unhandled error is here too.
| @@ -62,7 +62,7 @@ func TestPermissionsRequestBuilder_NewPermissionsRequest(t *testing.T) { | |||
| Convey("should return get user permissions request if inbound request contains user auth header", t, func() { | |||
| builder := &PermissionsRequestBuilder{Host: testHost} | |||
| inboundReq := httptest.NewRequest("GET", testHost, nil) | |||
| headers.SetUserAuthToken(inboundReq, "666") | |||
| headers.SetAuthToken(inboundReq, "666") | |||
| }) | ||
|
|
||
| Convey("should return get user permissions request if inbound request contains both user and service auth headers", t, func() { | ||
| builder := &PermissionsRequestBuilder{Host: testHost} | ||
| inboundReq := httptest.NewRequest("GET", testHost, nil) | ||
| headers.SetServiceAuthToken(inboundReq, "666") | ||
| headers.SetUserAuthToken(inboundReq, "777") | ||
| headers.SetAuthToken(inboundReq, "777") |
|
Hi @cookel2 , the files you refer to are unit tests and handling the errors there would be pointless as those are not the functions in test but only setting pre requisites. It would make the test more difficult to read without adding any value - if if failed, the test would fail anyway. Plus it is not new code and that was present before this change. |
cookel2
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies.
Move to dp-api-clients v2 whose
headers.SetAuthTokennot only sets theX-Florence-Tokenheader but also theAuthorizationheader (see https://github.com/ONSdigital/dp-api-clients-go/blob/6cf6846c101baca1a39cf1e7a5726578e97ec964/headers/headers.go#L209-L224), hence amending unit tests