Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix location of java after openjdk moved in docker image #7

Merged
merged 1 commit into from
May 28, 2019

Conversation

NickGrantX
Copy link
Contributor

Motivation and Context

The docker image openjdk:11-slim has changed the location of the java binary.

What has changed

Changed the java path to the correct one.

How to test?

Build the image. Container should start.

Links

Trello: https://trello.com/c/7ivpCfY6
Reasons why stuff got broken: docker-library/openjdk#320 (comment)

Screenshots (if appropriate):

@NickGrantX
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented May 28, 2019

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #7   +/-   ##
=========================================
  Coverage     84.13%   84.13%           
  Complexity      192      192           
=========================================
  Files            32       32           
  Lines           435      435           
  Branches         18       18           
=========================================
  Hits            366      366           
  Misses           61       61           
  Partials          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d92e1e...cee317f. Read the comment docs.

@NickGrantX NickGrantX requested a review from rjweeks May 28, 2019 11:22
@NickGrantX NickGrantX merged commit 220bdc8 into master May 28, 2019
@NickGrantX NickGrantX deleted the fix-java-location-move-openjdk-slim-image branch May 28, 2019 11:23
@AdamHawtin AdamHawtin added this to the v1.0.0 milestone Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants