This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
Fix: Fixed type errors revealed by Cypress. #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Nitron
requested review from
designorant,
completer,
patrickjfl and
vmilitaru
|
✔️ Deploy Preview for ons-data-map ready! 🔨 Explore the source changes: 5221a8a 🔍 Inspect the deploy log: https://app.netlify.com/sites/ons-data-map/deploys/621f4f6b400d420008bb589f 😎 Browse the preview: https://deploy-preview-167--ons-data-map.netlify.app |
|
Nice one! Would you mind linking the discussion to that undocumented lifecycle method? |
Good shout, link is mapbox/mapbox-gl-js#2268 |
|
Hmm, using an undocumented API sounds quite a drastic solution. |
|
My thoughts are it points to something else being wrong, but I’m happy for now if it gets marked with a big warning comment and a link to @mourner’s comment. @designorant |
designorant
suggested changes
Mar 2, 2022
…nto fix/invalid-type-347
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type issues:
Map.svelte:
container needs to be either a string or HTMLElement.Fix: Wait for the container to be defined before generating the map.
Tileset.svelte:
"Cannot read properties of undefined (reading 'getSource')"Fix: map.isStyleLoaded(id) was causing the error. A Github discussion suggested using
map.on(style.loaded)which is an undocumented Mapbox lifecycle event. Using the above stops these errors from generating and after comparing to https://ons-data-map.netlify.app/ looks as if everything still works as expected and seems like there might be a slight speed increase with styles loading.ONSAutosuggest.svelte
Uncaught TypeError: Cannot read property 'innerText' of nullFix: Check input exists before attempting to extract innerText.