analizators/s1854

ONLYOFFICE · Jan 21, 2022 · f3d8b8d · f3d8b8d
1 parent 2f5a70e
commit f3d8b8d
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 16 deletions.
diff --git a/common/services/ASC.ElasticSearch/Engine/BaseIndexer.cs b/common/services/ASC.ElasticSearch/Engine/BaseIndexer.cs
@@ -258,7 +258,6 @@ internal async Task IndexAsync(List<T> data, bool immediately = true)
                             {
                                 wwd.Document.Data = null;
                                 wwd.Document = null;
-                                wwd = null;
                                 GC.Collect();
                             }
                             continue;
@@ -288,7 +287,6 @@ internal async Task IndexAsync(List<T> data, bool immediately = true)
                                 doc.Document.Data = null;
                                 doc.Document = null;
                             }
-                            doc = null;
                         }
 
                         portionStart = i;

diff --git a/products/ASC.Files/Core/HttpHandlers/FileHandler.ashx.cs b/products/ASC.Files/Core/HttpHandlers/FileHandler.ashx.cs
@@ -272,18 +272,13 @@ private async Task InternalBulkDownloadFile(HttpContext context, IDataStore stor
         {
             try
             {
-                var flushed = false;
                 using (var readStream = store.GetReadStream(FileConstant.StorageDomainTmp, path))
                 {
                     long offset = 0;
-                    var length = readStream.Length;
                     if (readStream.CanSeek)
                     {
-                        length = ProcessRangeHeader(context, readStream.Length, ref offset);
                         readStream.Seek(offset, SeekOrigin.Begin);
-                    }
-
-                    flushed = await SendStreamByChunksAsync(context, length, FileConstant.DownloadTitle + ext, readStream, flushed);
+                    }
                 }
 
                 await context.Response.Body.FlushAsync();

diff --git a/products/ASC.Files/Core/HttpHandlers/SearchHandler.cs b/products/ASC.Files/Core/HttpHandlers/SearchHandler.cs
@@ -119,7 +119,7 @@ public IEnumerable<Folder<int>> SearchFolders(string text)
                     //result = result.Concat(EntryManager.GetThirpartyFolders(folderMy, text));
                 }
 
-                id = GlobalFolderHelper.FolderCommon;
+                //id = GlobalFolderHelper.FolderCommon;
                 //var folderCommon = folderDao.GetFolder(id);
                 //result = result.Concat(EntryManager.GetThirpartyFolders(folderCommon, text));
             }

diff --git a/products/ASC.Files/Core/Utils/EntryManager.cs b/products/ASC.Files/Core/Utils/EntryManager.cs
@@ -350,7 +350,7 @@ public IEnumerable<FileEntry> GetEntries<T>(Folder<T> parent, int from, int coun
                 const string responseBody = null;// apiServer.GetApiResponse(apiUrl, "GET");
                 if (responseBody != null)
                 {
-                    var responseApi = JObject.Parse(Encoding.UTF8.GetString(Convert.FromBase64String(responseBody)));
+                    JObject responseApi;
 
                     Dictionary<int, KeyValuePair<int, string>> folderIDProjectTitle = null;
 

diff --git a/web/ASC.Web.Api/Controllers/SettingsController.cs b/web/ASC.Web.Api/Controllers/SettingsController.cs
@@ -3011,7 +3011,7 @@ private void CheckCache(string basekey)
                     throw new Exception(Resource.ErrorRequestLimitExceeded);
             }
 
-            MemoryCache.Set(key, ++count, TimeSpan.FromMinutes(expirationMinutes));
+            MemoryCache.Set(key, count + 1, TimeSpan.FromMinutes(expirationMinutes));
         }
     }
 }
diff --git a/web/ASC.Web.Core/Notify/StudioPeriodicNotify.cs b/web/ASC.Web.Core/Notify/StudioPeriodicNotify.cs
@@ -72,7 +72,7 @@ public void SendSaasLetters(string senderName, DateTime scheduleDate)
 
             Log.Info("Start SendSaasTariffLetters");
 
-            var activeTenants = new List<Tenant>();
+            List<Tenant> activeTenants;
 
             using (var scope = ServiceProvider.CreateScope())
             {
@@ -871,7 +871,7 @@ public void SendOpensourceLetters(string senderName, DateTime scheduleDate)
 
             Log.Info("Start SendOpensourceTariffLetters");
 
-            var activeTenants = new List<Tenant>();
+            List<Tenant> activeTenants;
 
             using (var scope = ServiceProvider.CreateScope())
             {

diff --git a/web/ASC.Web.Core/Sms/SmsKeyStorage.cs b/web/ASC.Web.Core/Sms/SmsKeyStorage.cs
@@ -174,7 +174,7 @@ public Result ValidateKey(string phone, string key)
                 if (createDate.Add(StoreInterval) < DateTime.UtcNow)
                     return Result.Timeout;
 
-                CheckCache.Insert(cacheCheck, (--counter).ToString(CultureInfo.InvariantCulture), DateTime.UtcNow.Add(StoreInterval));
+                CheckCache.Insert(cacheCheck, (counter - 1).ToString(CultureInfo.InvariantCulture), DateTime.UtcNow.Add(StoreInterval));
                 return Result.Ok;
             }
         }

diff --git a/web/ASC.Web.Core/Tfa/TfaManager.cs b/web/ASC.Web.Core/Tfa/TfaManager.cs
@@ -155,7 +155,7 @@ public bool ValidateAuthCode(UserInfo user, string code, bool checkBackup = true
                 }
             }
 
-            Cache.Insert("tfa/" + user.ID, (--counter).ToString(CultureInfo.InvariantCulture), DateTime.UtcNow.Add(TimeSpan.FromMinutes(1)));
+            Cache.Insert("tfa/" + user.ID, (counter - 1).ToString(CultureInfo.InvariantCulture), DateTime.UtcNow.Add(TimeSpan.FromMinutes(1)));
 
             if (!SecurityContext.IsAuthenticated)
             {
@@ -179,7 +179,7 @@ public IEnumerable<BackupCode> GenerateBackupCodes()
 
             const string alphabet = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890-_";
 
-            var data = new byte[length];
+            byte[] data;
 
             var list = new List<BackupCode>();