Merge branch 'hotfix/v1.0.1' of github.com:ONLYOFFICE/AppServer into …

…hotfix/v1.0.1
ONLYOFFICE · Nov 11, 2021 · ae0a437 · ae0a437
2 parents 4c55228 + 738cacb
commit ae0a437
Show file tree

Hide file tree

Showing 76 changed files with 1,567 additions and 237 deletions.
diff --git a/build/install/common/systemd/build.sh b/build/install/common/systemd/build.sh
@@ -36,7 +36,7 @@ BASE_DIR="/var/www/${PRODUCT}"
 PATH_TO_CONF="/etc/onlyoffice/${PRODUCT}"
 STORAGE_ROOT="${PATH_TO_CONF}/data"
 LOG_DIR="/var/log/onlyoffice/${PRODUCT}"
-DOTNET_RUN="/usr/bin/dotnet"
+DOTNET_RUN="/usr/share/dotnet/dotnet"
 APP_URLS="http://0.0.0.0"
 ENVIRONMENT=" --ENVIRONMENT=production"
 

diff --git a/common/Tests/Frontend.Translations.Tests/LocalesTest.cs b/common/Tests/Frontend.Translations.Tests/LocalesTest.cs
@@ -428,8 +428,9 @@ public void NotFoundKeysTest()
                  .Select(item => item.Key);
 
             var allJsTranslationKeys = JavaScriptFiles
+                .Where(f => !f.Path.Contains("Banner.js")) // skip Banner.js (translations from firebase)
                 .SelectMany(j => j.TranslationKeys)
-                .Select(k => k.Replace("Common:", "").Replace("Translations:", ""))
+                .Select(k => k.Replace("Common:", "").Replace("Translations:", "").Replace("Home:", ""))
                 .Distinct();
 
             var notFoundJsKeys = allJsTranslationKeys.Except(allEnKeys);

diff --git a/packages/asc-web-common/api/files/index.js b/packages/asc-web-common/api/files/index.js
@@ -48,6 +48,10 @@ export function getFolderPath(folderId) {
 }
 
 export function getFolder(folderId, filter) {
+  if (folderId && typeof folderId === "string") {
+    folderId = encodeURIComponent(folderId.replace(/\\\\/g, "\\"));
+  }
+
   const params =
     filter && filter instanceof FilesFilter
       ? `${folderId}?${filter.toApiUrlParams()}`

diff --git a/packages/asc-web-common/api/people/index.js b/packages/asc-web-common/api/people/index.js
@@ -2,6 +2,7 @@ import { request } from "../client";
 //import axios from "axios";
 import Filter from "./filter";
 import * as fakePeople from "./fake";
+import { Encoder } from "../../utils/encoder";
 
 export function getUserList(filter = Filter.getDefault(), fake = false) {
   if (fake) {
@@ -18,6 +19,14 @@ export function getUserList(filter = Filter.getDefault(), fake = false) {
   return request({
     method: "get",
     url: `/people${params}`,
+  }).then((res) => {
+    res.items = res.items.map((user) => {
+      if (user && user.displayName) {
+        user.displayName = Encoder.htmlDecode(user.displayName);
+      }
+      return user;
+    });
+    return res;
   });
 }
 
@@ -26,6 +35,11 @@ export function getUser(userName = null) {
     method: "get",
     url: `/people/${userName || "@self"}.json`,
     skipUnauthorized: true,
+  }).then((user) => {
+    if (user && user.displayName) {
+      user.displayName = Encoder.htmlDecode(user.displayName);
+    }
+    return user;
   });
 }
 export function getUserPhoto(userId) {
@@ -156,6 +170,11 @@ export function updateUserCulture(id, cultureName) {
     method: "put",
     url: `/people/${id}/culture`,
     data: { cultureName },
+  }).then((user) => {
+    if (user && user.displayName) {
+      user.displayName = Encoder.htmlDecode(user.displayName);
+    }
+    return user;
   });
 }
 

diff --git a/packages/asc-web-common/components/MediaViewer/sub-components/image-viewer.js b/packages/asc-web-common/components/MediaViewer/sub-components/image-viewer.js
@@ -13,6 +13,7 @@ import MediaDownloadIcon from "../../../../../public/images/media.download.react
 import commonIconsStyles from "@appserver/components/utils/common-icons-style";
 import MediaScrollButton from "./scroll-button";
 import ControlBtn from "./control-btn";
+import equal from "fast-deep-equal/react";
 
 const StyledMediaZoomInIcon = styled(MediaZoomInIcon)`
   ${commonIconsStyles}
@@ -228,6 +229,9 @@ class ImageViewer extends React.Component {
       document.getElementsByClassName("iconContainer reset")[0].click();
   }
 
+  shouldComponentUpdate(nextProps) {
+    return !equal(this.props, nextProps);
+  }
   render() {
     const {
       className,

diff --git a/packages/asc-web-common/components/PageLayout/i18n.js b/packages/asc-web-common/components/PageLayout/i18n.js
@@ -10,7 +10,7 @@ i18n
   .init({
     lng: localStorage.getItem(LANGUAGE) || "en",
     fallbackLng: "en",
-    load: "all",
+    load: "currentOnly",
     //debug: true,
 
     interpolation: {

diff --git a/packages/asc-web-common/components/PageLayout/sub-components/section-paging.js b/packages/asc-web-common/components/PageLayout/sub-components/section-paging.js
@@ -7,10 +7,6 @@ const StyledSectionPaging = styled.div`
 `;
 
 class SectionPaging extends React.Component {
-  shouldComponentUpdate(nextProps) {
-    return !equal(this.props, nextProps);
-  }
-
   render() {
     return <StyledSectionPaging {...this.props} />;
   }

diff --git a/packages/asc-web-common/store/AuthStore.js b/packages/asc-web-common/store/AuthStore.js
@@ -19,7 +19,6 @@ class AuthStore {
   tfaStore = null;
 
   isLoading = false;
-  isAuthenticated = false;
   version = null;
   skipModules = false;
   providers = [];
@@ -42,8 +41,6 @@ class AuthStore {
 
     await this.userStore.init();
 
-    if (this.userStore.user) this.setIsAuthenticated(true);
-
     const requests = [];
     requests.push(this.settingsStore.init());
 
@@ -202,15 +199,17 @@ class AuthStore {
     }
   };
 
-  reset = () => {
+  reset = (skipUser = false) => {
     this.isInit = false;
     this.skipModules = false;
-    this.userStore = new UserStore();
+    if (!skipUser) {
+      this.userStore = new UserStore();
+    }
     this.moduleStore = new ModuleStore();
     this.settingsStore = new SettingsStore();
   };
 
-  logout = async (withoutRedirect) => {
+  logout = async (redirectToLogin = true) => {
     await api.user.logout();
 
     //console.log("Logout response ", response);
@@ -221,22 +220,24 @@ class AuthStore {
 
     isDesktop && logoutDesktop();
 
-    this.reset();
-
-    this.init();
-
-    if (!withoutRedirect) {
+    if (redirectToLogin) {
       if (personal) {
-        window.location.replace("/");
+        return window.location.replace("/");
       } else {
-        history.push(combineUrl(proxyURL, "/login"));
+        this.reset(true);
+        this.userStore.setUser(null);
+        this.init();
+        return history.push(combineUrl(proxyURL, "/login"));
       }
+    } else {
+      this.reset();
+      this.init();
     }
   };
 
-  setIsAuthenticated = (isAuthenticated) => {
-    this.isAuthenticated = isAuthenticated;
-  };
+  get isAuthenticated() {
+    return this.userStore.isAuthenticated;
+  }
 
   getEncryptionAccess = (fileId) => {
     return api.files

diff --git a/packages/asc-web-common/store/UserStore.js b/packages/asc-web-common/store/UserStore.js
@@ -1,4 +1,4 @@
-import { action, makeObservable, observable } from "mobx";
+import { makeAutoObservable } from "mobx";
 import api from "../api";
 
 class UserStore {
@@ -8,29 +8,20 @@ class UserStore {
   userIsUpdate = false;
 
   constructor() {
-    makeObservable(this, {
-      user: observable,
-      isLoading: observable,
-      isLoaded: observable,
-      userIsUpdate: observable,
-      getCurrentUser: action,
-      setIsLoading: action,
-      setIsLoaded: action,
-      setUser: action,
-      setUserIsUpdate: action,
-    });
+    makeAutoObservable(this);
   }
 
-  getCurrentUser = async () => {
+  loadCurrentUser = async () => {
     const user = await api.people.getUser();
-
     this.setUser(user);
   };
 
   init = async () => {
+    if (this.isLoaded) return;
+
     this.setIsLoading(true);
 
-    await this.getCurrentUser();
+    await this.loadCurrentUser();
 
     this.setIsLoading(false);
     this.setIsLoaded(true);
@@ -61,6 +52,10 @@ class UserStore {
     //console.log("setUserIsUpdate");
     this.userIsUpdate = isUpdate;
   };
+
+  get isAuthenticated() {
+    return !!this.user;
+  }
 }
 
 export default UserStore;