Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop member profile #4107

Closed
wants to merge 12 commits into from
Closed

Conversation

CrowsVeldt
Copy link
Contributor

@CrowsVeldt CrowsVeldt commented Jan 25, 2025

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)
  • Code style update
  • Refactoring (no functional changes)
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Remove MemberProfile component and update SpaceProfile component to replace it.

Does this PR introduce a DB Schema Change or Migration?

  • Yes
  • No

Git Issues

Closes #4100

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on Discord in the Community Platform development channel.

@CrowsVeldt CrowsVeldt requested a review from a team as a code owner January 25, 2025 15:07
Copy link

cypress bot commented Jan 25, 2025

onearmy-community-platform    Run #6832

Run Properties:  status check failed Failed #6832  •  git commit a1b484561d: fix: removed unused import
Project onearmy-community-platform
Branch Review pull/4107
Run status status check failed Failed #6832
Run duration 05m 28s
Commit git commit a1b484561d: fix: removed unused import
Committer CrowsVeldt
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 78
View all changes introduced in this branch ↗︎

Tests for review

Failed  src/integration/profile.spec.ts • 1 failed test • ci-chrome

View Output Video

Test Artifacts
[Profile] > [By User] > [User directed to own profile] Test Replay Screenshots Video
Flakiness  library/read.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[How To] > [List Library Projects] > [By Everyone] Test Replay Screenshots Video
Flakiness  research/follow.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Research] > [By Authenticated] > [Follow button] Test Replay Screenshots Video

@CrowsVeldt CrowsVeldt closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[ui] [refactor] Drop MemberProfile
1 participant