-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop member profile #4107
Closed
Closed
Drop member profile #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform Run #6832
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/4107
|
Run status |
Failed #6832
|
Run duration | 05m 28s |
Commit |
a1b484561d: fix: removed unused import
|
Committer | CrowsVeldt |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
2
|
Pending |
0
|
Skipped |
0
|
Passing |
78
|
View all changes introduced in this branch ↗︎ |
Tests for review
src/integration/profile.spec.ts • 1 failed test • ci-chrome
Test | Artifacts | |
---|---|---|
[Profile] > [By User] > [User directed to own profile] |
Test Replay
Screenshots
Video
|
library/read.spec.ts • 1 flaky test • ci-chrome
Test | Artifacts | |
---|---|---|
[How To] > [List Library Projects] > [By Everyone] |
Test Replay
Screenshots
Video
|
research/follow.spec.ts • 1 flaky test • ci-chrome
Test | Artifacts | |
---|---|---|
[Research] > [By Authenticated] > [Follow button] |
Test Replay
Screenshots
Video
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Remove MemberProfile component and update SpaceProfile component to replace it.
Does this PR introduce a DB Schema Change or Migration?
Git Issues
Closes #4100
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
development
channel.