Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/questions supabase #4053

Merged
merged 43 commits into from
Jan 18, 2025
Merged

Feat/questions supabase #4053

merged 43 commits into from
Jan 18, 2025

Conversation

mariojsnunes
Copy link
Contributor

@mariojsnunes mariojsnunes commented Dec 28, 2024 •
edited
Loading

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes)

What is the current behavior?

Questions are stored in firebase.

What is the new behavior?

Questions are stored in supabase.
Also migrated:

  • tags
  • useful
  • follow (subscribers)

Question images are also saved in supabase storage.
Removed moderation code for questions (wasn't being used in the UI)

TODO:

  • can we have a custom supabase cdn url? (so we don't expose the supabase url)
  • document storage migration/setup
  • data migration

Does this PR introduce a breaking change?

  • Yes
  • No

Git Issues

Closes #4059 and #3918

@mariojsnunes mariojsnunes requested a review from a team as a code owner December 28, 2024 17:29
@benfurber
Copy link
Member

Niiiice, I'll have a look today.

@cypress Cypress
Copy link

cypress bot commented Jan 9, 2025 •
edited
Loading

onearmy-community-platform    Run #6789

Run Properties:  status check passed Passed #6789  •  git commit 53be17b78c: chore: flaky map test
Project onearmy-community-platform
Branch Review feat/questions-supabase
Run status status check passed Passed #6789
Run duration 05m 22s
Commit git commit 53be17b78c: chore: flaky map test
Committer Mário Nunes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 79
View all changes introduced in this branch ↗︎

benfurber
benfurber reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@benfurber benfurber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coool! Really clear direction will all of this. Nice one.

Left a bunch of comments, obvs. Big thing from me I think is what would be unit tested out of all this, there's lots of key system behaviour here.

packages/cypress/src/integration/questions/search.spec.ts Outdated Show resolved Hide resolved
packages/cypress/src/integration/questions/read.spec.ts Outdated Show resolved Hide resolved
packages/cypress/src/integration/questions/discussions.spec.ts Show resolved Hide resolved
packages/cypress/src/integration/questions/read.spec.ts Outdated Show resolved Hide resolved
shared/mocks/data/categories.ts Show resolved Hide resolved
src/routes/api.subscribers.$contentType.$contentId.ts Show resolved Hide resolved
src/routes/api.subscribers.$contentType.$contentId.ts Show resolved Hide resolved
src/services/questionService.ts Show resolved Hide resolved
src/services/questionService.ts Show resolved Hide resolved
vite.config.ts.timestamp-1736550923998-a30767ea98555.mjs Outdated Show resolved Hide resolved
benfurber
benfurber approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@benfurber benfurber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're still missing a unit testing approach but not essential for this PR.

packages/cypress/src/integration/questions/read.spec.ts Outdated Show resolved Hide resolved
shared/mocks/data/categories.ts Show resolved Hide resolved
src/common/Form/TagsSelectFieldV2.tsx Outdated Show resolved Hide resolved
@mariojsnunes mariojsnunes removed the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jan 18, 2025
@mariojsnunes mariojsnunes merged commit d32dc3c into master Jan 18, 2025
19 checks passed
@mariojsnunes mariojsnunes deleted the feat/questions-supabase branch January 18, 2025 18:53
@mariojsnunes mariojsnunes mentioned this pull request Jan 18, 2025
Closed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 2.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfurber benfurber benfurber approved these changes

Assignees
No one assigned
Labels
Mod: HowTo 📰 Mod: Library 📰 Mod: Research 🔬 released
Projects
Community Platform
Status: Done
Core Team - BAU list
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Move questions to Supabase
3 participants
@mariojsnunes @benfurber @onearmy-bot