ftp: completely resets port_line #8379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case port_line is first allocated and port_line_len is set, Then a second request reaches memcap and frees port_line, port_line_len should also be reset, because both will get used by the response parsing. Ticket: OISF#5701
victorjulien
approved these changes
Jan 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8379 +/- ##
==========================================
+ Coverage 81.92% 81.94% +0.02%
==========================================
Files 963 963
Lines 277674 277675 +1
==========================================
+ Hits 227472 227535 +63
+ Misses 50202 50140 -62
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 11610 |
|
Merged in #8389, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5701
Describe changes:
As approved on Gitlab