This repository has been archived by the owner on Jan 5, 2022. It is now read-only.
Edit ran link #235
Merged
Edit ran link #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
combines javascript but nothing else, as the partials would need a lot of locals passed in, I think
Sgtpluck
approved these changes
Nov 8, 2021
| format.js { render inline: "location.reload(true);" } | ||
| else | ||
| format.js { render inline: "alert('there was an error changing the id of the RAN review');" } | ||
| # format.js { render "update_errors" } |
There was a problem hiding this comment.
[nitpick] please remove this comment!
There was a problem hiding this comment.
I left it in there as a reminder to put it back in if we do #207 , but I can remove it and the matching TTA one and just leave a comment in the issue, if you prefer!
There was a problem hiding this comment.
i'd prefer it to be a TODO to make what needs to happen really clear, if you want to leave it in the code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Adds editing functionality to the monitoring link on a complaint detail page. Ideal error functionality was not in this issue, but can be done as part of #207 if we get there.
Acceptance Criteria
How to test
Go to a complaint detail page, choose an existing linked review (or add one if there isn't anything already), click the pencil icon, change the number, check that it saved correctly!
Issue(s)
Checklist
To be completed by the submitter:
To the Reviewer
This project is using Conventional Comments to give structure
and context to PR comments. Please use these labels in your comments.